port some parts of webkit/glue/plugins/test to Linux...

webkit/glue/plugins/test/plugin_test.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/string_util.h"
 #include "webkit/glue/plugins/test/plugin_test.h"
 #include "webkit/glue/plugins/test/npapi_constants.h"
 
 namespace NPAPIClient {
 
 PluginTest::PluginTest(NPP id, NPNetscapeFuncs *host_functions) {
   id_ = id;
   id_->pdata = this;
   host_functions_ = host_functions;
 }
@@ skipping 10 matching lines @@
 }
 
 // It's a shame I have to implement URLEncode.  But, using webkit's
 // or using chrome's means a ball of string of dlls and dependencies that
 // is very very long.  After spending far too much time on it,
 // I'll just encode it myself.  Too bad Microsoft doesn't implement
 // this in a reusable way either.  Both webkit and chrome will
 // end up using libicu, which is a string of dependencies we don't
 // want.
 
-inline BYTE toHex(const BYTE &x) {
+inline unsigned char toHex(const unsigned char &x) {
     return x > 9 ? x + 55: x + 48;

[Mark Mentovai, 2008/09/16 17:53:36]

Existing code, but I think this is far less obtuse as:

return x > 9 ? (x + 'A' - 10) : (x + '0');

and the indent should be two spaces.

 }
 
 std::string URLEncode(const std::string &sIn) {
   std::string sOut;
 
   const size_t length = sIn.length();
   for (size_t idx = 0; idx < length;) {
     const char ch = sIn.at(idx);
     if (isalnum(ch)) {
       sOut.append(1, ch);
@@ skipping 34 matching lines @@
   }
   script_url = URLEncode(script_url);
   script_result.append("javascript:");
   script_result.append(script_url);
   host_functions_->geturl(id_, script_result.c_str(), "_self");
 }
 
 const char *PluginTest::GetArgValue(const char *name, const int16 argc,
                                     const char *argn[], const char *argv[]) {
   for (int idx = 0; idx < argc; idx++)
-    if (_stricmp(argn[idx], name) == 0)
+    if (base::strcasecmp(argn[idx], name) == 0)
       return argv[idx];
   return NULL;
 }
 
 void PluginTest::SetError(const std::string &msg) {
   test_status_.append(msg);
 }
 
 NPError PluginTest::NewStream(NPMIMEType type, NPStream* stream,
                               NPBool seekable, uint16* stype) {
@@ skipping 25 matching lines @@
   // There is no default action
 }
 
 int16 PluginTest::HandleEvent(void* event) {
   // There is no default action
   return 0;
 }
 
 } // namespace NPAPIClient