Issue 16580: Don't DCHECK if a watched directory doesn't exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16580: Don't DCHECK if a watched directory doesn't exist. (Closed)

Created:
11 years, 11 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Don't DCHECK if a watched directory doesn't exist. The caller can't easily check whether a directory exists before calling this functions. Also modify GreasemonkeyMaster to allow this condition.

Patch Set 1 #

Total comments: 3

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	base/directory_watcher_unittest.cc	View	1 chunk	+9 lines, -0 lines	1 comment	Download
M	base/directory_watcher_win.cc	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	chrome/browser/greasemonkey_master.cc	View	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 11 months ago (2009-01-07 18:47:57 UTC) #2

LGTM

http://codereview.chromium.org/16580/diff/1/2
File base/directory_watcher_unittest.cc (right):

http://codereview.chromium.org/16580/diff/1/2#newcode191
Line 191: TEST_F(DirectoryWatcherTest, NonExistantDirectory) {
s/Existant/Existent/

http://codereview.chromium.org/16580/diff/1/3
File base/directory_watcher_win.cc (right):

http://codereview.chromium.org/16580/diff/1/3#newcode51
Line 51: if (handle_ == INVALID_HANDLE_VALUE) {
can remove the curlies now if you care

http://codereview.chromium.org/16580/diff/1/4
File chrome/browser/greasemonkey_master.cc (right):

http://codereview.chromium.org/16580/diff/1/4#newcode172
Line 172: if (ok) {
can do "if (dir_watcher_->Watch...)" and eliminate ok variable

Expand Messages | Collapse Messages