Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5415)

Unified Diff: chrome/browser/greasemonkey_master.cc

Issue 16580: Don't DCHECK if a watched directory doesn't exist. (Closed)
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/directory_watcher_win.cc ('K') | « base/directory_watcher_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/greasemonkey_master.cc
diff --git a/chrome/browser/greasemonkey_master.cc b/chrome/browser/greasemonkey_master.cc
index 11c3085cc24f8c560e351b0a1ac03130d86fc694..af56129c3fbe272890b34ce41de2ace0e4116198 100644
--- a/chrome/browser/greasemonkey_master.cc
+++ b/chrome/browser/greasemonkey_master.cc
@@ -169,10 +169,10 @@ GreasemonkeyMaster::GreasemonkeyMaster(MessageLoop* worker_loop,
pending_scan_(false) {
// Watch our scripts directory for modifications.
bool ok = dir_watcher_->Watch(script_dir, this);
- DCHECK(ok);
-
- // (Asynchronously) scan for our initial set of scripts.
- StartScan();
+ if (ok) {
Evan Martin 2009/01/07 18:47:57 can do "if (dir_watcher_->Watch...)" and eliminate
+ // (Asynchronously) scan for our initial set of scripts.
+ StartScan();
+ }
}
GreasemonkeyMaster::~GreasemonkeyMaster() {
« base/directory_watcher_win.cc ('K') | « base/directory_watcher_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698