This change implements the performance recommendation from: ...

This change implements the performance recommendation from: 
http://msdn.microsoft.com/en-us/library/aa383153(VS.85).aspx

This fixes the performance problem of resolving PAC query when WinHTTP AutoProxy service is running, which seems to at least be default on Vista and Win2k3.

Contributed by griffinz@gmail.com

BUG=1684
R=nsylvain


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1924

[darin (slow to review), 2008-09-09 05:46:12]

This is http://codereview.chromium.org/1656 cleaned up to conform to the style
guide.

[Jesse, 2008-09-09 06:31:43]

Looks good, thanks for the quick help with this Nicolas, Darin and Ian.

[Nicolas Sylvain, 2008-09-09 15:18:12]

Thanks !

One small comment:

http://codereview.chromium.org/1657/diff/3/203
File net/proxy/proxy_resolver_winhttp.cc (right):

http://codereview.chromium.org/1657/diff/3/203#newcode118
Line 118: LOG(ERROR) << "WinHttpGetProxyForUrl failed: " << error;
Can you put this line in the other "if (!ok)" under, because right now it will
log an error only if the first error was ERROR_WINHTTP_LOGIN_FAILURE. I think we
should remove this "if(!ok)" completely and just fallback on the other one.

[Jesse, 2008-09-09 17:44:53]

I have made updates to http://codereview.chromium.org/1656, since I don't think
I could update here.

[wtc, 2008-09-09 19:03:10]

I agree with Nicolas's suggestion of moving the
LOG(ERROR) code.

http://codereview.chromium.org/1657/diff/3/203
File net/proxy/proxy_resolver_winhttp.cc (right):

http://codereview.chromium.org/1657/diff/3/203#newcode104
Line 104: // Otherwise, we failover to trying it with a value of true.  This way
we get
Nit: "fail over", two words.

http://codereview.chromium.org/1657/diff/3/203#newcode105
Line 105: // good performance in the case where WinHTTP uses an out-of-proc
resolver.
Nit: "out-of-process"