This change implements the performance recommendation from: ...

This change implements the performance recommendation from: 
http://msdn.microsoft.com/en-us/library/aa383153(VS.85).aspx
This fixes the performance problem of resolving query... when
WinHTTP AutoProxy service is running.  Which seems to at least 
be default on Vista & w2k3.


************To improve performance************

Call WinHttpGetProxyForUrl with the fAutoLogonIfChallenged parameter set to false. 
The autoproxy URL and script are cached for future calls to WinHttpGetProxyForUrl.
If Step 1 fails, with ERROR_WINHTTP_LOGIN_FAILURE, then call WinHttpGetProxyForUrl 
with the fAutoLogonIfChallenged member set to true.

BUG=1684

[griffinz, 2008-09-09 05:15:23]

http://code.google.com/p/chromium/issues/detail?id=1684

[ian fette, 2008-09-09 06:00:04]

First of all, thank you for contributing. We all appreciate it. I have a few
style nits here - we follow the Google C++ Style Guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml), to keep the
style of the code consistent. It makes it easier to read and maintain when the
code maintains consistent style throughout. I have pointed out some style
issues, not necessarily complete but I think it's most of these. Please address
these issues. (Darin and Nicolas may have other comments).

Again, thank you for your time and effort, and please don't be offended by the
style nits.

http://codereview.chromium.org/1656/diff/1/2
File net/proxy/proxy_resolver_winhttp.cc (right):

http://codereview.chromium.org/1656/diff/1/2#newcode103
Line 103: session_handle_, ASCIIToWide(query_url).c_str(), &options, &info))) {
Too much indentation - either indent four spaces more than the if is indented,
or try to line up the arguments if it will fit that way, e.g.
foo(
    arg1,
    arg2);

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

http://codereview.chromium.org/1656/diff/1/2#newcode107
Line 107: if(ERROR_WINHTTP_LOGIN_FAILURE == error)
this line should be at the same indentation level as the LOG() line above

http://codereview.chromium.org/1656/diff/1/2#newcode108
Line 108: {
Curly braces on same line as the if statement

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...

http://codereview.chromium.org/1656/diff/1/2#newcode109
Line 109: options.fAutoLogonIfChallenged = TRUE;
In the patch, it looks like you have a tab. Please avoid using tabs and use only
spaces. Indentation is two spaces.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Spaces...

http://codereview.chromium.org/1656/diff/1/2#newcode111
Line 111: session_handle_, ASCIIToWide(query_url).c_str(), &options, &info))) {
Again, indentation. Make sure you are using spaces not tabs. The arguments for
CallWinHttpGetProxyForUrl should be aligned as noted earlier (either underneath
and to the right of the function, or on the next line with 4 spaces indentation)

http://codereview.chromium.org/1656/diff/1/2#newcode118
Line 118: {
This if block looks like it's still indented two spaces too much. Also, curly
brace on same line as conditional.

http://codereview.chromium.org/1656/diff/1/2#newcode119
Line 119: // If we got here because of RPC timeout during out of process PAC
No lines over 80 characters, although I suspect once you fix indentation this
will be fine

http://codereview.chromium.org/1656/diff/1/2#newcode122
Line 122: (ERROR_WINHTTP_AUTO_PROXY_SERVICE_ERROR == error)) {
Looks like you have a tab here. Since it doesn't fit on previous line,
indentation is 4 spaces.

[wtc, 2008-09-09 19:08:24]

LGTM.

http://codereview.chromium.org/1656/diff/21/209
File net/proxy/proxy_resolver_winhttp.cc (right):

http://codereview.chromium.org/1656/diff/21/209#newcode104
Line 104: // Otherwise, we failover to trying it with a value of true.  This way
we get
Nit: "fail over", two words.

http://codereview.chromium.org/1656/diff/21/209#newcode105
Line 105: // good performance in the case where WinHTTP uses an out-of-proc
resolver.
Nit: "out-of-process".

http://codereview.chromium.org/1656/diff/21/209#newcode118
Line 118: if(!ok) {
Add a space after "if".