Add UMR for PrependInteger to exceptions list for base_unittests.exe....

Add UMR for PrependInteger to exceptions list for base_unittests.exe.

This purify filter is already in the unit_tests.exe_UMR_flakey.txt file, so this is just bringing that hack to base.

BUG=http://crbug.com/18795

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23441

[eroman, 2009-08-14 17:27:37]

I should mention, I haven't been able to test this locally (since the UMR is
presumably flakey).

What I did here was to add a _flakey.txt file, and copy-paste the callstack off
of buildbot page.

[Erik does not do reviews, 2009-08-14 17:29:16]

Reference bug 18795 in the CL description.

You grabbed the wrong stack trace to put in here (normalized stacks
don't have line numbers).  The normalized stack can be found here:
http://build.chromium.org/buildbot/purify/base/23439/base_unittests.exe_UMR=
.txt
(this is from the "download" link from the waterfall bubble for the
purify tests)

Otherwise, LGTM

Erik


On Fri, Aug 14, 2009 at 10:24 AM, <eroman@chromium.org> wrote:
> Reviewers: Erik Kay, Marc-Antoine Ruel,
>
> Description:
> Add UMR for PrependInteger to exceptions list for base_unittests.exe.
>
> This purify filter is already in the unit_tests.exe_UMR_flakey.txt file,
> so this is just bringing that hack to base.
>
>
> Please review this at http://codereview.chromium.org/165540
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0A =A0 =A0 base/data/purify/base_unittests.exe_UMR_flakey.txt
>
>
> Index: base/data/purify/base_unittests.exe_UMR_flakey.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- base/data/purify/base_unittests.exe_UMR_flakey.txt =A0(revision 0)
> +++ base/data/purify/base_unittests.exe_UMR_flakey.txt =A0(revision 0)
> @@ -0,0 +1,14 @@
> +Uninitialized memory read in `anonymous namespace'::PrependInteger
> +Error Location
> + =A0 base/crypto/rsa_private_key_win.cc:90 =A0`anonymous
> namespace'::PrependInteger
> + =A0 base/crypto/rsa_private_key_win.cc:406
> =A0base::RSAPrivateKey::ExportPrivateKey(vector::std *)
> + =A0 base/crypto/rsa_private_key_unittest.cc:22
> =A0RSAPrivateKeyUnitTest_InitRandomTest_Test::TestBody(void)
> + =A0 testing/gtest/src/gtest.cc:2031 =A0testing::Test::Run(void)
> + =A0 ^^^
> +Alloc Location
> + =A0 ...
> + =A0 base/crypto/rsa_private_key_win.cc:361
> =A0base::RSAPrivateKey::ExportPrivateKey(vector::std *)
> + =A0 base/crypto/rsa_private_key_unittest.cc:22
> =A0RSAPrivateKeyUnitTest_InitRandomTest_Test::TestBody(void)
> + =A0 testing/gtest/src/gtest.cc:2031 =A0testing::Test::Run(void)
> + =A0 ^^^
> +
>
> Property changes on: base\data\purify\base_unittests.exe_UMR_flakey.txt
> ___________________________________________________________________
> Added: svn:eol-style
> =A0 + native
>
>
>
>

[eroman, 2009-08-14 17:34:08]

> Reference bug 18795 in the CL description.

Done.

> You grabbed the wrong stack trace to put in here (normalized stacks
> don't have line numbers).

Ah, thanks for spotting!
Done.

[M-A Ruel, 2009-08-14 17:44:25]

For my part, rubberstamp lgtm

On Aug 14, 2009 1:34 PM, <eroman@chromium.org> wrote:

> Reference bug 18795 in the CL description.
Done.

> You grabbed the wrong stack trace to put in here (normalized stacks >
don't have line numbers). ...
Ah, thanks for spotting!
Done.

http://codereview.chromium.org/165540

[Erik does not do reviews, 2009-08-14 17:49:40]

LGTM


On Fri, Aug 14, 2009 at 10:34 AM, <eroman@chromium.org> wrote:
>> Reference bug 18795 in the CL description.
>
> Done.
>
>> You grabbed the wrong stack trace to put in here (normalized stacks
>> don't have line numbers).
>
> Ah, thanks for spotting!
> Done.
>
> http://codereview.chromium.org/165540
>