Add an easy way to do a synchronous connect from test code.

Add an easy way to do a synchronous connect from test code.
(As Darin requested in review 16207, I now do this with
a helper class rather than by trying to directly support it.)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7641

[Erik does not do reviews, 2009-01-06 22:28:41]

LGTM

http://codereview.chromium.org/16549/diff/205/207
File net/base/tcp_client_socket.h (right):

http://codereview.chromium.org/16549/diff/205/207#newcode137
Line 137: class TCPClientSocketSyncConnector
I'd probably prefer this to be in its own header file if it's likely to be used
by multiple tests.  Otherwise, I'd just stick it in the test itself.  Add a TODO
if you'd rather wait to do this later.

http://codereview.chromium.org/16549/diff/205/207#newcode151
Line 151: TCPClientSocketSyncConnector* connector =
you could do this as a scoped_refptr instead of the explicit AddRef/Release.

http://codereview.chromium.org/16549/diff/205/207#newcode188
Line 188: }
add a newline here

[darin (slow to review), 2009-01-08 19:31:09]

http://codereview.chromium.org/16549/diff/214/7
File net/base/tcp_client_socket.h (right):

http://codereview.chromium.org/16549/diff/214/7#newcode138
Line 138: class TCPClientSocketSyncConnector
our convention has been to put testing-only code like this in a separate header
file.  see test_completion_callback.h for instance.  please do something similar
for this class.