Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 165477: Merge 23332 - Take 2 at fixing anchor links opening in background tabs on lin... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 23332 - Take 2 at fixing anchor links opening in background tabs on linux. Also fix a code path that seems to be missing on Windows (maybe this regressed?). This time make sure RWHV is not NULL. BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/165468 TBR=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
MM chrome/browser/browser.cc View 1 chunk +12 lines, -0 lines 0 comments Download
MM chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-13 19:23:20 UTC) #1
tony
11 years, 4 months ago (2009-08-13 19:33:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698