Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 165468: Take 2 at fixing anchor links opening in background tabs on linux. (Closed)

Created:
11 years, 4 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Nate Chapin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Take 2 at fixing anchor links opening in background tabs on linux. Also fix a code path that seems to be missing on Windows (maybe this regressed?). This time make sure RWHV is not NULL. BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/browser.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +10 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 4 months ago (2009-08-13 17:47:55 UTC) #1
Nate Chapin
http://codereview.chromium.org/165468/diff/1/3 File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right): http://codereview.chromium.org/165468/diff/1/3#newcode582 Line 582: if (tab_contents()->render_widget_host_view()) { I don't have a great ...
11 years, 4 months ago (2009-08-13 18:24:36 UTC) #2
Evan Stade
11 years, 4 months ago (2009-08-13 18:30:52 UTC) #3
lgtm

http://codereview.chromium.org/165468/diff/1/3
File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right):

http://codereview.chromium.org/165468/diff/1/3#newcode582
Line 582: if (tab_contents()->render_widget_host_view()) {
On 2009/08/13 18:24:36, Nate Chapin wrote:
> I don't have a great understanding of this layer of the code, so pardon my
dumb
> question:  Is there any reason we would want to initialize the RWHV here
instead
> of doing nothing if it's null?

The tab contents view doesn't own the RWHV, so no.

Powered by Google App Engine
This is Rietveld 408576698