Issue 165330: Disable RTTI and C++ exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165330: Disable RTTI and C++ exceptions (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disable RTTI and C++ exceptions in the Mac build. Disable RTTI in the Linux build, where C++ exceptions are already disabled. BUG=19094 12248 TEST=Mac release-mode Google Chrome.app should shrink by about 6MB. Mac disk image should shrink by about 1.5MB. Linux binary and package should shrink too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23304

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -90 lines)			Patch
M	base/file_path.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	base/hash_tables.h	View	1	2 chunks	+43 lines, -74 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	1 2 3 4 5	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/nsimage_cache.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/nsimage_cache.mm	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/profile.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	testing/gtest.gyp	View	1 2 3 4	1 chunk	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

This needs to wait until we have https://bugs.webkit.org/show_bug.cgi?id=28204 for the Mac.

11 years, 4 months ago (2009-08-12 04:57:58 UTC) #1

Dean McNamee

11 years, 4 months ago (2009-08-12 22:58:47 UTC) #3

LGTM, we didn't need the wchar* etc hashers?

Also, I'd be surprised if the Linux build shrinks, we don't actually use RTTI
anywhere, so I don't think any info was being emitted.

Expand Messages | Collapse Messages