Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: testing/gtest.gyp

Issue 165330: Disable RTTI and C++ exceptions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profile.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/gtest.gyp
===================================================================
--- testing/gtest.gyp (revision 23061)
+++ testing/gtest.gyp (working copy)
@@ -52,7 +52,28 @@
'gtest/include',
],
'conditions': [
- [ 'OS == "mac"', { 'sources': [ 'platform_test_mac.mm' ] } ],
+ ['OS == "mac"', {
+ 'sources': [
+ 'platform_test_mac.mm'
+ ],
+ }],
+ ['OS == "mac" or OS == "linux"', {
+ 'defines': [
+ # gtest isn't able to figure out when RTTI is disabled for gcc
+ # versions older than 4.3.2, and assumes it's enabled. Our Mac
+ # and Linux builds disable RTTI, and cannot guarantee that the
+ # compiler will be 4.3.2. or newer. The Mac, for example, uses
+ # 4.2.1 as that is the latest available on that platform. gtest
+ # must be instructed that RTTI is disabled here, and for any
+ # direct dependents that might include gtest headers.
+ 'GTEST_HAS_RTTI=0',
+ ],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'GTEST_HAS_RTTI=0',
+ ],
+ },
+ }],
],
'direct_dependent_settings': {
'defines': [
« no previous file with comments | « chrome/browser/profile.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698