Build browser/sync files by default using a stubbed-out syncapi...

Build browser/sync files by default using a stubbed-out syncapi
implementation.  The stub will be replaced once the rest of
sync/engine lands as we open source the sync engine code.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23004

[tim (not reviewing), 2009-08-11 00:28:35]

bradnelson, please look over / sanity check the .gypi/.gyp changes.

idana, please review everything.

[tim (not reviewing), 2009-08-11 00:31:07]

I should mention that I added the 'use_syncapi_stub' option in common.gypi to
make it easy to turn off the static stub and patch-in syncapi.dll when we need
to.

[bradn, 2009-08-11 00:38:01]

gyp changes LGTM

[idana, 2009-08-11 00:53:29]

LGTM

[Mark Mentovai, 2009-08-11 04:10:04]

http://codereview.chromium.org/165257/diff/72/1104
File build/common.gypi (right):

http://codereview.chromium.org/165257/diff/72/1104#newcode195
Line 195: 'defines': ['COMPILING_SYNCAPI_STUB'],
Did we really need to define this for every single file that we build?  Couldn't
we have restricted it a bit more, like to chrome.gyp?

[tim (not reviewing), 2009-08-11 18:56:59]

http://codereview.chromium.org/165257/diff/72/1104
File build/common.gypi (right):

http://codereview.chromium.org/165257/diff/72/1104#newcode195
Line 195: 'defines': ['COMPILING_SYNCAPI_STUB'],
We don't need this for every single file we build, but I wanted a simple
place/way to patch this setting via a python script we use to swap in the
syncapi DLL, and we already patched this file to set the chrome_personalization
variable.  I think that var ended up in here originally because we used to set
it in essential.vsprops, and so when gyp came around it was moved here.  

It is needed by multiple targets in chrome.gyp, so it probably does belong
there.  I'll try to move it today, thanks for pointing this out. 

On 2009/08/11 04:10:04, Mark Mentovai wrote:
> Did we really need to define this for every single file that we build? 
Couldn't
> we have restricted it a bit more, like to chrome.gyp?

[Mark Mentovai, 2009-08-11 19:07:28]

Thanks.  If the personalization macro can be scoped more narrowly
(such as to chrome.gyp), that'd be a good change too.

Mark

tim@chromium.org wrote:
> http://codereview.chromium.org/165257/diff/72/1104
> File build/common.gypi (right):
>
> http://codereview.chromium.org/165257/diff/72/1104#newcode195
> Line 195: 'defines': ['COMPILING_SYNCAPI_STUB'],
> We don't need this for every single file we build, but I wanted a simple
> place/way to patch this setting via a python script we use to swap in
> the syncapi DLL, and we already patched this file to set the
> chrome_personalization variable. =A0I think that var ended up in here
> originally because we used to set it in essential.vsprops, and so when
> gyp came around it was moved here.
>
> It is needed by multiple targets in chrome.gyp, so it probably does
> belong there. =A0I'll try to move it today, thanks for pointing this out.

[Bruno, 2009-08-13 21:37:53]

Hi Tim,

When you say, "as we open source the sync engine code", are you referring to the
code on the XMPP-based Google Talk server?

Thanks for your response.

Bruno

[tim (not reviewing), 2009-08-15 00:49:43]

On 2009/08/13 21:37:53, Bruno wrote:
> Hi Tim,
> 
> When you say, "as we open source the sync engine code", are you referring to
the
> code on the XMPP-based Google Talk server?
> 
> Thanks for your response.
> 
> Bruno

I'm referring to the full client-side library for syncing bookmarks. See
http://dev.chromium.org/developers/design-documents/sync or
http://groups.google.com/group/chromium-dev/browse_thread/thread/bdacc1bdf3c5...