Build browser/sync files by default using a stubbed-out syncapi...

build/common.gypi

Index: build/common.gypi
===================================================================
--- build/common.gypi	(revision 23002)
+++ build/common.gypi	(working copy)
@@ -94,8 +94,12 @@
 
     'chromeos%': 0,
 
-    'chrome_personalization%': 0,
+    # Whether or not browser sync code is built in.
+    'chrome_personalization%': 1,
 
+    # Used to build and statically link a stub (no-op) syncapi engine.
+    'use_syncapi_stub%' : 1,
+
     # Set the restrictions on the SUID sandbox binary.
     #  Path: only exec the hard coded chrome binary path
     #  User: only exec binaries owned by the running user.
@@ -180,8 +184,16 @@
         'defines': ['OS_CHROMEOS=1'],
       }],
       ['chrome_personalization==1', {
-        'defines': ['CHROME_PERSONALIZATION=1'],
-      }],
+        'conditions': [
+         ['OS=="win"', {
+           # For now sync is only enabled on windows.
+           'defines': ['CHROME_PERSONALIZATION=1'],
+         }],  # OS==win
+        ],  # conditions for chrome_personalization
+      }],  # chrome_personalization==1
+      ['use_syncapi_stub==1', {
+       'defines': ['COMPILING_SYNCAPI_STUB'],

[Mark Mentovai, 2009/08/11 04:10:04]

Did we really need to define this for every single file that we build?  Couldn't
we have restricted it a bit more, like to chrome.gyp?

[tim (not reviewing), 2009/08/11 18:57:00]

We don't need this for every single file we build, but I wanted a simple
place/way to patch this setting via a python script we use to swap in the
syncapi DLL, and we already patched this file to set the chrome_personalization
variable.  I think that var ended up in here originally because we used to set
it in essential.vsprops, and so when gyp came around it was moved here.  

It is needed by multiple targets in chrome.gyp, so it probably does belong
there.  I'll try to move it today, thanks for pointing this out. 

On 2009/08/11 04:10:04, Mark Mentovai wrote:

+      }],  # use_syncapi_stub==1
       ['coverage!=0', {
         'conditions': [
           ['OS=="mac"', {