Turning on incremental linking for 64-bit machines.

Turning on incremental linking for 64-bit machines.

BUG=18646
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22790

[M-A Ruel, 2009-08-07 18:25:47]

crazy cool, lgtm

On Aug 7, 2009 2:21 PM, <bradnelson@google.com> wrote:

Reviewers: Marc-Antoine Ruel,

Description:
Turning on incremental linking for 64-bit machines.

BUG=18646
TEST=None


Please review this at http://codereview.chromium.org/165140

SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Affected files:
 M     build/common.gypi
 M     chrome/chrome.gyp


Index: build/common.gypi
===================================================================
--- build/common.gypi   (revision 22737)
+++ build/common.gypi   (working copy)
@@ -151,6 +151,12 @@
          },{
            'msvs_multi_core_compile%': 1,
          }],
+          # Don't do incremental linking for large modules on 32-bit.
+          ['MSVS_OS_BITS==32', {
+            'msvs_large_module_debug_link_mode%': '1',  # No
+          },{
+            'msvs_large_module_debug_link_mode%': '2',  # Yes
+          }],
        ],
      }],
    ],
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp   (revision 22737)
+++ chrome/chrome.gyp   (working copy)
@@ -4061,7 +4061,7 @@
              'msvs_precompiled_source':
'tools/build/win/precompiled_wtl.cc',
              'msvs_settings': {
                'VCLinkerTool': {
-                  'LinkIncremental': '1',       # /INCREMENTAL:NO
+                  'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                },
              },
            },
@@ -4355,7 +4355,7 @@
                'Debug': {
                  'msvs_settings': {
                    'VCLinkerTool': {
-                      'LinkIncremental': '1',       # /INCREMENTAL:NO
+                      'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                    },
                  },
                },
@@ -4600,7 +4600,7 @@
            'Debug': {
              'msvs_settings': {
                'VCLinkerTool': {
-                  'LinkIncremental': '1',       # /INCREMENTAL:NO
+                  'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                },
              },
            },
@@ -4978,7 +4978,7 @@
              'msvs_precompiled_source':
'tools/build/win/precompiled_wtl.cc',
              'msvs_settings': {
                'VCLinkerTool': {
-                  'LinkIncremental': '1',       # /INCREMENTAL:NO
+                  'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                },
              },
            },
@@ -5147,7 +5147,7 @@
              'msvs_precompiled_source':
'tools/build/win/precompiled_wtl.cc',
              'msvs_settings': {
                'VCLinkerTool': {
-                  'LinkIncremental': '1',       # /INCREMENTAL:NO
+                  'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                },
              },
            },
@@ -5296,7 +5296,7 @@
            'Debug': {
              'msvs_settings': {
                'VCLinkerTool': {
-                  'LinkIncremental': '1',       # /INCREMENTAL:NO
+                  'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
                },
              },
            },