Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 165133: Bounce through a set so we uniq the string list to avoid having something lis... (Closed)

Created:
11 years, 4 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Bounce through a set so we uniq the string list to avoid having something listed twice (a sub menu ends up with the same title as the menu item it hangs off, so it's easy to get dups within a xib file). TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22734

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/mac/generate_localizer View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
TVL
11 years, 4 months ago (2009-08-07 16:29:57 UTC) #1
Mark Mentovai
http://codereview.chromium.org/165133/diff/1/2 File build/mac/generate_localizer (right): http://codereview.chromium.org/165133/diff/1/2#newcode103 Line 103: constants_list.sort() Even better: constants_list = sorted(set(constants_list))
11 years, 4 months ago (2009-08-07 16:38:48 UTC) #2
Mark Mentovai
11 years, 4 months ago (2009-08-07 16:38:54 UTC) #3
p.s. lgtm

Powered by Google App Engine
This is Rietveld 408576698