build/mac/generate_localizer - Issue 165133: Bounce through a set so we uniq the string list to avoid having something lis...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/mac/generate_localizer

Issue 165133: Bounce through a set so we uniq the string list to avoid having something lis... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/mac/generate_localizer

===================================================================

--- build/mac/generate_localizer (revision 22731)

+++ build/mac/generate_localizer (working copy)

@@ -97,8 +97,9 @@

def generate_files_contents(class_name, constants_list, header_name, xib_path):

"""Generates a localizer files contents from the list of constants."""

- # Copy and sort the list, then build the strings we need from it.

- constants_list = constants_list[:]

+ # Bounce through a set to uniq the strings, sort the list, then build the

+ # values we need from it.

+ constants_list = list(set(constants_list))

constants_list.sort()

Mark Mentovai 2009/08/07 16:38:48 Even better: constants_list = sorted(set(constant

constant_list_str = ''

for item in constants_list:

« no previous file with comments | « no previous file | no next file » | no next file with comments »