Issue 165103: Add 'rpm' to dev tools for creating RPM packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165103: Add 'rpm' to dev tools for creating RPM packages. (Closed)

Created:
11 years, 4 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add 'rpm' to dev tools for creating RPM packages.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dkegel

11 years, 4 months ago (2009-08-06 23:37:50 UTC) #2

LGTM... (is rpm 4.4.2.1 too new?   There might be some version problems
lurking ahead.)

On Thu, Aug 6, 2009 at 4:33 PM, <mmoss@chromium.org> wrote:
> Reviewers: Lei Zhang, dank,
>
> Description:
> Add 'rpm' to dev tools for creating RPM packages.
>
> Please review this at http://codereview.chromium.org/165103
>
> Affected files:
> =A0M build/install-build-deps.sh
>
>
> Index: build/install-build-deps.sh
> diff --git a/build/install-build-deps.sh b/build/install-build-deps.sh
> index
> b586e7eb3c06c93f3131e560ddce5e15f8a5e967..70744fb6096c9808fb7b09daf0390d6=
af6e6c760
> 100755
> --- a/build/install-build-deps.sh
> +++ b/build/install-build-deps.sh
> @@ -90,7 +90,7 @@ fi
> =A0dev_list=3D"bison fakeroot flex g++ g++-multilib gperf libasound2-dev
> =A0 =A0 =A0 =A0 =A0 libcairo2-dev libgconf2-dev libglib2.0-dev libgtk2.0-=
dev
> libnspr4-dev
> =A0 =A0 =A0 =A0 =A0 libnss3-dev libsqlite3-dev lighttpd msttcorefonts pat=
ch perl
> php5-cgi
> - =A0 =A0 =A0 =A0 =A0pkg-config python subversion wdiff"
> + =A0 =A0 =A0 =A0 =A0pkg-config python rpm subversion wdiff"
>
> =A0# Full list of required run-time libraries
> =A0lib_list=3D"libatk1.0-0 libc6 libasound2 libcairo2 libexpat1 libfontco=
nfig1
>
>
>

Expand Messages | Collapse Messages