Fix Issue 18530....

When importing bookmarks from Firefox, filter out the default bookmarks.

The existing code attempted to do this but it had a bug.

BUG=18530

[Evan Martin, 2009-08-07 01:35:49]

Does this fix it on Linux, or is just just a logic fix for the code?  You link
to a Linux bug but the comment just above your change says it's Windows-only.

I rearranged your review description, I hope you don't mind.

http://codereview.chromium.org/165094/diff/1/2
File chrome/browser/importer/firefox2_importer.cc (right):

http://codereview.chromium.org/165094/diff/1/2#newcode84
Line 84: file = file.AppendASCII("bookmarks.html");
!!! So this is why it wasn't work on Windows!

It might be simpler to write it as 
file = file.AppendASCII("defaults").AppendASCII("profile").etc

[douglas.muir, 2009-08-07 16:15:58]

It fixes it on Linux.  I'll correct the comment.  Do you recommend combining
the AppendASCII's into one line?

-Doug

On Thu, Aug 6, 2009 at 6:35 PM, <evan@chromium.org> wrote:

> Does this fix it on Linux, or is just just a logic fix for the code?
> You link to a Linux bug but the comment just above your change says it's
> Windows-only.
>
> I rearranged your review description, I hope you don't mind.
>
>
> http://codereview.chromium.org/165094/diff/1/2
> File chrome/browser/importer/firefox2_importer.cc (right):
>
> http://codereview.chromium.org/165094/diff/1/2#newcode84
> Line 84: file = file.AppendASCII("bookmarks.html");
> !!! So this is why it wasn't work on Windows!
>
> It might be simpler to write it as
> file = file.AppendASCII("defaults").AppendASCII("profile").etc
>
> http://codereview.chromium.org/165094
>

[Evan Martin, 2009-08-07 17:59:25]

On 2009/08/07 16:15:58, douglas.muir wrote:
> It fixes it on Linux.  I'll correct the comment.

Ok, cool.

> Do you recommend combining
> the AppendASCII's into one line?

Your call.

[douglas.muir, 2009-08-07 21:57:31]

OK, I removed the Windows only comment, but left the AppendASCIIs on 
separate lines.

On 2009/08/07 17:59:25, Evan Martin wrote:
> On 2009/08/07 16:15:58, douglas.muir wrote:
> > It fixes it on Linux.  I'll correct the comment.
> 
> Ok, cool.
> 
> > Do you recommend combining
> > the AppendASCII's into one line?
> 
> Your call.

[Evan Martin, 2009-08-09 05:21:34]

r22884, thanks