Make gclient pass correct relative paths to the hooks.

Make gclient pass correct relative paths to the hooks.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23026

[Paweł Hajdan Jr., 2009-08-06 19:19:08]

patch updated

[M-A Ruel, 2009-08-06 19:25:55]

http://codereview.chromium.org/165070/diff/4/5
File gclient.py (right):

http://codereview.chromium.org/165070/diff/4/5#newcode935
Line 935: command = ['status', self.relpath]
I'm not sure about that.

http://codereview.chromium.org/165070/diff/1005/1006#newcode1328
Line 1328: self._options.revision = None
scm.RunCommand() is called at many places so you may want to do that below just
before runhooks or depending on what you want exactly.

[Paweł Hajdan Jr., 2009-08-06 21:44:00]

Please review. This patch does everything I want to the paths.

[M-A Ruel, 2009-08-06 22:53:29]

http://codereview.chromium.org/165070/diff/9/1008
File gclient.py (right):

http://codereview.chromium.org/165070/diff/9/1008#newcode1375
Line 1375: if not os.path.isabs(file_list[i]):
That should be deterministic.

[M-A Ruel, 2009-08-10 15:58:12]

lgtm with the comment

http://codereview.chromium.org/165070/diff/9/1008
File gclient.py (right):

http://codereview.chromium.org/165070/diff/9/1008#newcode1375
Line 1375: if not os.path.isabs(file_list[i]):
On 2009/08/06 22:53:29, Marc-Antoine Ruel wrote:
> That should be deterministic.

Just add a #TODO(you): Make it deterministic to be always absolute paths with
runhooks and status.