Make gclient pass correct relative paths to the hooks.

gclient.py

 #!/usr/bin/python
 #
 # Copyright 2008 Google Inc.  All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #      http://www.apache.org/licenses/LICENSE-2.0
 #
@@ skipping 1307 matching lines @@
     for solution in solutions:
       name = solution["name"]
       if name in entries:
         raise Error("solution %s specified more than once" % name)
       url = solution["url"]
       entries[name] = url
       if run_scm:
         self._options.revision = revision_overrides.get(name)
         scm = SCMWrapper(url, self._root_dir, name)
         scm.RunCommand(command, self._options, args, file_list)
+        file_list = [os.path.join(name, file.strip()) for file in file_list]
         self._options.revision = None
       try:
         deps_content = FileRead(os.path.join(self._root_dir, name,
                                              self._options.deps_file))
       except IOError, e:
         if e.errno != errno.ENOENT:
           raise
         deps_content = ""
       entries_deps_content[name] = deps_content
 
@@ skipping 23 matching lines @@
                                                  deps[d].module_name,
                                                  self._options.deps_file)),
                            {})
         url = sub_deps[d]
         entries[d] = url
         if run_scm:
           self._options.revision = revision_overrides.get(d)
           scm = SCMWrapper(url, self._root_dir, d)
           scm.RunCommand(command, self._options, args, file_list)
           self._options.revision = None
+    
+    # Convert all absolute paths to relative.
+    for i in range(len(file_list)):
+      if not os.path.isabs(file_list[i]):

[M-A Ruel, 2009/08/06 22:53:29]

That should be deterministic.

[M-A Ruel, 2009/08/10 15:58:12]

Just add a #TODO(you): Make it deterministic to be always absolute paths with
runhooks and status.

+        continue
+
+      prefix = os.path.commonprefix([self._root_dir.lower(),
+                                     file_list[i].lower()])
+      file_list[i] = file_list[i][len(prefix):]
+
+      # Strip any leading path separators.
+      while file_list[i].startswith('\\') or file_list[i].startswith('/'):
+        file_list[i] = file_list[i][1:]
 
     is_using_git = IsUsingGit(self._root_dir, entries.keys())
     self._RunHooks(command, file_list, is_using_git)
 
     if command == 'update':
       # Notify the user if there is an orphaned entry in their working copy.
       # Only delete the directory if there are no changes in it, and
       # delete_unversioned_trees is set to true.
       prev_entries = self._ReadEntries()
       for entry in prev_entries:
@@ skipping 414 matching lines @@
 
 if "__main__" == __name__:
   try:
     result = Main(sys.argv)
   except Error, e:
     print >> sys.stderr, "Error: %s" % str(e)
     result = 1
   sys.exit(result)
 
 # vim: ts=2:sw=2:tw=80:et: