Issue 164543: Reverting 23406.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164543: Reverting 23406. (Closed)

Created:
11 years, 4 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 23406. It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23411

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -111 lines)			Patch
M	base/window_impl.h	View	3 chunks	+14 lines, -20 lines	0 comments	Download
M	base/window_impl.cc	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget_win.cc	View	20 chunks	+33 lines, -33 lines	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/default_plugin/plugin_impl_win.h	View	5 chunks	+6 lines, -4 lines	0 comments	Download
M	webkit/default_plugin/plugin_impl_win.cc	View	16 chunks	+36 lines, -39 lines	0 comments	Download
M	webkit/tools/test_shell/foreground_helper.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

levin

This seems to have caused a consistent failure in Tab2OutOfTabStrip on the buildbots since I ...

11 years, 4 months ago (2009-08-14 02:59:44 UTC) #2

levin

11 years, 4 months ago (2009-08-14 05:53:58 UTC) #3

Sorry, it appears your check in was not the problem.  Please feel free to
put it back in.

On Thu, Aug 13, 2009 at 7:59 PM, <levin@chromium.org> wrote:

> This seems to have caused a consistent failure in Tab2OutOfTabStrip on
> the buildbots since I can't find you right now, I'm rolling this back to
> help green the tree some.
>
>
>
>
> http://codereview.chromium.org/164543
>

Expand Messages | Collapse Messages