Fixing == -> = for dash.

Fixing == -> = for dash.

BUG=None
TEST=None
TBR=rspangler


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23335

[Randall Spangler, 2009-08-13 18:54:40]

lgtm

[Mark Mentovai, 2009-08-13 19:05:13]

LGTM on the == to = change.  I do have some more comments on this script.

http://codereview.chromium.org/164496/diff/1/2
File hammer (right):

http://codereview.chromium.org/164496/diff/1/2#newcode17
Line 17: if `test "${SRC_DIR}" = "${PARENT_DIR}"`; then
The backticks aren't necessary.  Same for the "while" condition above. 
Generally, where backticks can be used (line 13), $(...) is preferred.

These days, it's more common to use [ ... ] instead of test.

On line 14, prefer

while [ ! -d ... ] || [ -e ... ] ; do

because the shell will short-circuit when you use its built-in boolean
operations.

Finally, on line 16, you're missing double-quotes around ${SRC_DIR}.  The entire
rest of the script seems to be resilient about spaces in variables, save for
that line.

[bradn, 2009-08-13 21:59:07]

Ok making additional changes in:http://codereview.chromium.org/165495


On Thu, Aug 13, 2009 at 12:05 PM, <mark@chromium.org> wrote:

> LGTM on the == to = change.  I do have some more comments on this
> script.
>
>
> http://codereview.chromium.org/164496/diff/1/2
> File hammer (right):
>
> http://codereview.chromium.org/164496/diff/1/2#newcode17
> Line 17: if `test "${SRC_DIR}" = "${PARENT_DIR}"`; then
> The backticks aren't necessary.  Same for the "while" condition above.
> Generally, where backticks can be used (line 13), $(...) is preferred.
>
> These days, it's more common to use [ ... ] instead of test.
>
> On line 14, prefer
>
> while [ ! -d ... ] || [ -e ... ] ; do
>
> because the shell will short-circuit when you use its built-in boolean
> operations.
>
> Finally, on line 16, you're missing double-quotes around ${SRC_DIR}.
> The entire rest of the script seems to be resilient about spaces in
> variables, save for that line.
>
>
> http://codereview.chromium.org/164496
>