Issue 164399: X64: Add an SHL optimization, fix a floating-point bug, fix xchg rax,r8 and p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164399: X64: Add an SHL optimization, fix a floating-point bug, fix xchg rax,r8 and p... (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Add an SHL optimization, fix a floating-point bug, fix xchg rax,r8 and printing of test ?ax, imm in disassembler. Committed: http://code.google.com/p/v8/source/detail?r=2673

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -5 lines)			Patch
	M	src/x64/codegen-x64.cc	View		4 chunks	+57 lines, -3 lines	0 comments	Download
	M	src/x64/disasm-x64.cc	View		2 chunks	+1 line, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/164399/diff/1/2 File src/x64/disasm-x64.cc (left): http://codereview.chromium.org/164399/diff/1/2#oldcode108 Line 108: { 0x90, UNSET_OP_ORDER, "nop" }, Was this ...

11 years, 4 months ago (2009-08-12 20:03:37 UTC) #2

William Hesse

11 years, 4 months ago (2009-08-13 07:59:36 UTC) #3

http://codereview.chromium.org/164399/diff/1/2
File src/x64/disasm-x64.cc (left):

http://codereview.chromium.org/164399/diff/1/2#oldcode108
Line 108: { 0x90, UNSET_OP_ORDER, "nop" },
On 2009/08/12 20:03:37, Erik Corry wrote:
> Was this deliberate?
Yes.  This instruction is handled by code, because one 64-bit case of it is no
longer NOP, but xchg rax, r8.

Expand Messages | Collapse Messages