Issue 164325: Save debugging symbols for plugin_carbon_interpose.dylib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164325: Save debugging symbols for plugin_carbon_interpose.dylib (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Save debugging symbols for plugin_carbon_interpose.dylib. BUG=18997 TEST=Release build produces plugin_carbon_interpose.dylib-*-i386.breakpad, and Google Chrome.dsym.tar.bz2 contains plugin_carbon_interpose.dylib.dSYM Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23043

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	build/mac/dump_app_syms	View	1	1 chunk	+12 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/164325/diff/1/2 File build/mac/dump_app_syms (right): http://codereview.chromium.org/164325/diff/1/2#newcode60 Line 60: BPAD_SYM_NAME="${SRC_NAME}-${FULL_VERSION}-${ARCH}.breakpad" Note: I'm changing this so that we ...

11 years, 4 months ago (2009-08-11 16:37:33 UTC) #1

TVL

lgtm http://codereview.chromium.org/164325/diff/1/2 File build/mac/dump_app_syms (right): http://codereview.chromium.org/164325/diff/1/2#newcode56 Line 56: SRC_STEM=$(echo "${SRC_NAME}" | sed -Ee 's/^(.*)\.(app|framework)$/\1/') worth ...

11 years, 4 months ago (2009-08-11 16:43:28 UTC) #2

Mark Mentovai

11 years, 4 months ago (2009-08-11 17:01:48 UTC) #4

TVL wrote:
> http://codereview.chromium.org/164325/diff/1/2#newcode56
> Line 56: SRC_STEM=$(echo "${SRC_NAME}" | sed -Ee
> 's/^(.*)\.(app|framework)$/\1/')
> worth a comment to note you keep .dylib on the name?

Commented.

Expand Messages | Collapse Messages