Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: build/mac/dump_app_syms

Issue 164325: Save debugging symbols for plugin_carbon_interpose.dylib (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/dump_app_syms
===================================================================
--- build/mac/dump_app_syms (revision 23027)
+++ build/mac/dump_app_syms (working copy)
@@ -49,15 +49,20 @@
declare -a DSYMS
-for SRC_BUNDLE in "${SRC_APP_NAME}.app" \
- "${SRC_APP_NAME} Framework.framework" \
- "${SRC_APP_NAME} Helper.app" ; do
- SRC_STEM=$(echo "${SRC_BUNDLE}" | sed -Ee 's/^(.*)\..*$/\1/')
- SRC_BUNDLE_PATH="${BUILT_PRODUCTS_DIR}/${SRC_BUNDLE}"
- DSYM_NAME="${SRC_BUNDLE}.dSYM"
+for SRC_NAME in "${SRC_APP_NAME}.app" \
+ "${SRC_APP_NAME} Framework.framework" \
+ "${SRC_APP_NAME} Helper.app" \
+ "plugin_carbon_interpose.dylib" ; do
+ # SRC_STEM is the name of the file within the DWARF directory of the .dSYM
+ # bundle, which comes from the on-disk name of an executable or dylib within
+ # its enclosing .app or .framework bundle. This is the bundle name without
+ # .app or .framework appended. For non-bundled types, the stem is just the
+ # name of the singlular file on disk.
+ SRC_STEM=$(echo "${SRC_NAME}" | sed -Ee 's/^(.*)\.(app|framework)$/\1/')
+ DSYM_NAME="${SRC_NAME}.dSYM"
DSYM_PATH="${BUILT_PRODUCTS_DIR}/${DSYM_NAME}"
DWARF_PATH="${DSYM_PATH}/Contents/Resources/DWARF/${SRC_STEM}"
- BPAD_SYM_NAME="${SRC_STEM}-${FULL_VERSION}-${ARCH}.breakpad"
+ BPAD_SYM_NAME="${SRC_NAME}-${FULL_VERSION}-${ARCH}.breakpad"
BPAD_SYM_PATH="${BUILT_PRODUCTS_DIR}/${BPAD_SYM_NAME}"
# Only run dump_syms if the file has changed since the last dump.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698