Issue 164303: Re-commit r22981 after backout at r22992

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164303: Re-commit r22981 after backout at r22992 (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google), stuartmorgan

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Re-commit r22981 after backout at r22992. Contains fixes to relocate plugin_carbon_interpose.dylib from the outer browser app bundle to the inner helper app bundle. Provide a separate app bundle for subprocesses like the renderer on the Mac. Remove LSUIElement and related hacks from the browser's app bundle. BUG=8044 TEST=Observe one Chromium and one or more Chromium Helper processes in Activity Monitor Review URL: http://codereview.chromium.org/164177 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23006

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -125 lines)			Patch
M	build/mac/dump_app_syms	View		2 chunks	+50 lines, -27 lines	0 comments	Download
M	build/mac/tweak_app_infoplist	View		9 chunks	+47 lines, -18 lines	0 comments	Download
M	chrome/app/app-Info.plist	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		3 chunks	+6 lines, -18 lines	0 comments	Download
M	chrome/browser/utility_process_host.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/browser/worker_host/worker_process_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	8 chunks	+124 lines, -48 lines	0 comments	Download
M	chrome/common/child_process_host.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_host.cc	View		2 chunks	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Must also fix http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf/builds/2027/steps/page_cycler_morejs/logs/stdio

11 years, 4 months ago (2009-08-11 02:26:34 UTC) #1

TVL

recommit looks good. you gonna make changes for the error you linked to first?

11 years, 4 months ago (2009-08-11 02:39:45 UTC) #2

Mark Mentovai

The only changes from the last version are in chrome.gyp. Rietveld will show them to ...

11 years, 4 months ago (2009-08-11 03:04:03 UTC) #3

lgtm

Expand Messages | Collapse Messages