Issue 1642018: Update the libmetrics API to match the new Chrome interface.

Issue 1642018: Update the libmetrics API to match the new Chrome interface. (Closed)

Created:
10 years, 8 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Visibility:
Public.

Description

Update the libmetrics API to match the new Chrome interface.

Patch Set 3 : New metrics directory. #

Patch Set 4 : New metrics file name. #

Patch Set 5 : move to /var/log/metrics #

Total comments: 4

Patch Set 6 : Address review comments. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -56 lines)			Patch
M	src/platform/init/chromeos_shutdown	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/platform/init/chromeos_startup	View	3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/platform/init/dump-boot-stats.conf	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/platform/metrics/metrics_client.cc	View		2 chunks	+16 lines, -18 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon.h	View	1 2 3 4 5	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/platform/metrics/metrics_daemon.cc	View	1 2 3 4	3 chunks	+14 lines, -12 lines	0 comments	Download
M	src/platform/metrics/metrics_library.h	View	1 2 3 4 5	1 chunk	+16 lines, -4 lines	0 comments	Download
M	src/platform/metrics/metrics_library.cc	View	1 2 3 4	5 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

Sending out for review in parallel with Luigi's Chrome change.

10 years, 8 months ago (2010-04-20 18:02:24 UTC) #1

sosa

nits for comments and lgtm once you address the comments http://codereview.chromium.org/1642018/diff/9001/10006 File src/platform/metrics/metrics_daemon.h (right): http://codereview.chromium.org/1642018/diff/9001/10006#newcode66 ...

10 years, 8 months ago (2010-04-21 21:03:51 UTC) #3

petkov

10 years, 8 months ago (2010-04-21 21:23:02 UTC) #4

Pushing...

http://codereview.chromium.org/1642018/diff/9001/10006
File src/platform/metrics/metrics_daemon.h (right):

http://codereview.chromium.org/1642018/diff/9001/10006#newcode66
src/platform/metrics/metrics_daemon.h:66: // Sends a stat to Chrome for
transport to UMA (or prints it for testing).
On 2010/04/21 21:03:51, sosa wrote:
> Can you add comments about what these fields mean

Done.

http://codereview.chromium.org/1642018/diff/9001/10008
File src/platform/metrics/metrics_library.h (right):

http://codereview.chromium.org/1642018/diff/9001/10008#newcode23
src/platform/metrics/metrics_library.h:23: // true on success. This method
results in an RPC to
On 2010/04/21 21:03:51, sosa wrote:
> This isn't a direct RPC.  Maybe change comment to reflect this

Done.

Expand Messages | Collapse Messages