Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Side by Side Diff: src/platform/metrics/metrics_library.h

Issue 1642018: Update the libmetrics API to match the new Chrome interface. (Closed)
Patch Set: Address review comments. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/platform/metrics/metrics_daemon.cc ('k') | src/platform/metrics/metrics_library.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /* 5 /*
6 * metrics_library.h 6 * metrics_library.h
7 * 7 *
8 * Created on: Dec 1, 2009 8 * Created on: Dec 1, 2009
9 * Author: sosa 9 * Author: sosa
10 */ 10 */
11 11
12 #ifndef METRICS_LIBRARY_H_ 12 #ifndef METRICS_LIBRARY_H_
13 #define METRICS_LIBRARY_H_ 13 #define METRICS_LIBRARY_H_
14 14
15 #include <string> 15 #include <string>
16 16
17 // TODO(sosa@chromium.org): Add testing for send methods 17 // TODO(sosa@chromium.org): Add testing for send methods
18 18
19 // Library used to send metrics both Autotest and Chrome 19 // Library used to send metrics both Autotest and Chrome.
20 class MetricsLibrary { 20 class MetricsLibrary {
21 public: 21 public:
22 // Sends histogram data to Chrome and returns true on success. 22 // Sends histogram data to Chrome for transport to UMA and returns
23 static bool SendToChrome(std::string name, int value); 23 // true on success. This method results in the equivalent of an
24 // asynchronous non-blocking RPC to UMA_HISTOGRAM_CUSTOM_COUNTS
25 // inside Chrome (see base/histogram.h).
26 //
27 // |sample| is the sample value to be recorded (|min| <= |sample| < |max|).
28 // |min| is the minimum value of the histogram samples (|min| > 0).
29 // |max| is the maximum value of the histogram samples.
30 // |nbuckets| is the number of histogram buckets.
31 // [0,min) is the implicit underflow bucket.
32 // [|max|,infinity) is the implicit overflow bucket.
33 static bool SendToChrome(const std::string& name, int sample,
34 int min, int max, int nbuckets);
35
24 // Sends to Autotest and returns true on success. 36 // Sends to Autotest and returns true on success.
25 static bool SendToAutotest(std::string name, int value); 37 static bool SendToAutotest(const std::string& name, int value);
26 }; 38 };
27 39
28 #endif /* METRICS_LIBRARY_H_ */ 40 #endif /* METRICS_LIBRARY_H_ */
OLDNEW
« no previous file with comments | « src/platform/metrics/metrics_daemon.cc ('k') | src/platform/metrics/metrics_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698