Issue 164068: Splice matching_files_list in $matching_files' place in gclient.py....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164068: Splice matching_files_list in $matching_files' place in gclient.py.... (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, M-A Ruel

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Splice matching_files_list in $matching_files' place in gclient.py. Based on Mark Mentovai's mail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22616

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	gclient.py	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 4 months ago (2009-08-06 16:57:12 UTC) #2

http://codereview.chromium.org/164068/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/164068/diff/1/2#newcode1237
Line 1237: command[splice_index:splice_index + 1] = matching_file_list
That works for multiple files? If so, lgtm.

Expand Messages | Collapse Messages