gclient.py - Issue 164068: Splice matching_files_list in $matching_files' place in gclient.py....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 164068: Splice matching_files_list in $matching_files' place in gclient.py.... (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient.py

===================================================================

--- gclient.py (revision 22609)

+++ gclient.py (working copy)

@@ -1233,8 +1233,8 @@

command[0] = sys.executable

if '$matching_files' in command:

- command.remove('$matching_files')

- command.extend(matching_file_list)

+ splice_index = command.index('$matching_files')

+ command[splice_index:splice_index + 1] = matching_file_list

M-A Ruel 2009/08/06 16:57:12 That works for multiple files? If so, lgtm.

# Use a discrete exit status code of 2 to indicate that a hook action

# failed. Users of this script may wish to treat hook action failures

« no previous file with comments | « no previous file | no next file » | no next file with comments »