Changes to bvt and nightly script.

Changes to bvt and nightly script. 
  1 add an extra tag name to logging_LogVolume since there are two tests with the same name.  
  2 remove hardware_VideoOut since it was renamed hardware_VideoOutSemiAuto.
  3 add firmware_VbootCrypto into nightly.

[kmixter1, 2010-04-07 17:34:06]

Sorry - I didn't realize logging_LogVolume was already in
default-argument list at the top.  Please remove the one in the list
and then the tag in the one with constraints shouldn't be necessary.

On Wed, Apr 7, 2010 at 10:31 AM,  <ericli@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Changes to bvt and nightly script.
>  1 add an extra tag name to logging_LogVolume since there are two tests with
> the same name.
>  2 remove hardware_VideoOut since it was renamed hardware_VideoOutSemiAuto.
>  3 add firmware_VbootCrypto into nightly.
>
> Please review this at http://codereview.chromium.org/1631005
>
> Affected files:
>  M server/site_tests/suite_BuildVerify/control
>  M server/site_tests/suite_Nightly/control
>
>
> Index: server/site_tests/suite_BuildVerify/control
> diff --git a/server/site_tests/suite_BuildVerify/control
> b/server/site_tests/suite_BuildVerify/control
> index
>
81e87f3bbebed0da015e04aee80f16356bf0824b..1680835956737fd49f4e01a8daf3417a48b9a6b3
> 100644
> --- a/server/site_tests/suite_BuildVerify/control
> +++ b/server/site_tests/suite_BuildVerify/control
> @@ -61,7 +61,6 @@ TESTS = [
>   # TODO(kmixter): Determine how to only run some tests on some
>   # platforms.  Until then pick a conservative set of BVTs.
>   #'hardware_SsdDetection',
> -  'hardware_VideoOut',
>   'logging_LogVolume',
>   'login_AuthenticationTests',
>   'login_PamModuleLoadTest',
> @@ -118,8 +117,8 @@ client_at.run_test('login_CryptohomeMounted',
> tag='success')
>  # problem with the patterns being too permissive by assuming most were
>  # required.
>  client_at.run_test('logging_LogVolume',
> -                  constraints=['percent_stateful_used <= 50',
> -                               'percent_unused_patterns <= 70'])
> +                   constraints=['percent_stateful_used <= 50',
> +                                'percent_unused_patterns <= 70'], tag='ex')
>
>  client_at.run_test('network_DisableInterface',
>                    iface_name='eth0', tag='eth0')
> Index: server/site_tests/suite_Nightly/control
> diff --git a/server/site_tests/suite_Nightly/control
> b/server/site_tests/suite_Nightly/control
> index
>
367bb8394e4711c6bc58c7840cec4561e64883e7..2f61ec4e6d970b77d75860c7bb9effe7a8f01338
> 100644
> --- a/server/site_tests/suite_Nightly/control
> +++ b/server/site_tests/suite_Nightly/control
> @@ -29,6 +29,7 @@ TESTS = [
>   'compilebench',
>   'dbench',
>   'disktest',
> +  'firmware_VbootCrypto',
>   'gl_Bench',
>   'hardware_StorageFio',
>   'ltp',
>
>
>

[ericli, 2010-04-07 18:44:46]

This is what I guessed. PTAL.

On 2010/04/07 17:34:06, kmixter1 wrote:
> Sorry - I didn't realize logging_LogVolume was already in
> default-argument list at the top.  Please remove the one in the list
> and then the tag in the one with constraints shouldn't be necessary.
> 
> On Wed, Apr 7, 2010 at 10:31 AM,  <mailto:ericli@chromium.org> wrote:
> > Reviewers: kmixter1,
> >
> > Description:
> > Changes to bvt and nightly script.
> > &nbsp;1 add an extra tag name to logging_LogVolume since there are two tests
with
> > the same name.
> > &nbsp;2 remove hardware_VideoOut since it was renamed
hardware_VideoOutSemiAuto.
> > &nbsp;3 add firmware_VbootCrypto into nightly.
> >
> > Please review this at http://codereview.chromium.org/1631005
> >
> > Affected files:
> > &nbsp;M server/site_tests/suite_BuildVerify/control
> > &nbsp;M server/site_tests/suite_Nightly/control
> >
> >
> > Index: server/site_tests/suite_BuildVerify/control
> > diff --git a/server/site_tests/suite_BuildVerify/control
> > b/server/site_tests/suite_BuildVerify/control
> > index
> >
>
81e87f3bbebed0da015e04aee80f16356bf0824b..1680835956737fd49f4e01a8daf3417a48b9a6b3
> > 100644
> > --- a/server/site_tests/suite_BuildVerify/control
> > +++ b/server/site_tests/suite_BuildVerify/control
> > @@ -61,7 +61,6 @@ TESTS = [
> > &nbsp; # TODO(kmixter): Determine how to only run some tests on some
> > &nbsp; # platforms. &nbsp;Until then pick a conservative set of BVTs.
> > &nbsp; #'hardware_SsdDetection',
> > - &nbsp;'hardware_VideoOut',
> > &nbsp; 'logging_LogVolume',
> > &nbsp; 'login_AuthenticationTests',
> > &nbsp; 'login_PamModuleLoadTest',
> > @@ -118,8 +117,8 @@ client_at.run_test('login_CryptohomeMounted',
> > tag='success')
> > &nbsp;# problem with the patterns being too permissive by assuming most were
> > &nbsp;# required.
> > &nbsp;client_at.run_test('logging_LogVolume',
> > - &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;constraints=['percent_stateful_used <= 50',
> > - &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 'percent_unused_patterns <= 70'])
> > + &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
constraints=['percent_stateful_used <= 50',
> > + &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;'percent_unused_patterns <= 70'],
tag='ex')
> >
> > &nbsp;client_at.run_test('network_DisableInterface',
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;iface_name='eth0', tag='eth0')
> > Index: server/site_tests/suite_Nightly/control
> > diff --git a/server/site_tests/suite_Nightly/control
> > b/server/site_tests/suite_Nightly/control
> > index
> >
>
367bb8394e4711c6bc58c7840cec4561e64883e7..2f61ec4e6d970b77d75860c7bb9effe7a8f01338
> > 100644
> > --- a/server/site_tests/suite_Nightly/control
> > +++ b/server/site_tests/suite_Nightly/control
> > @@ -29,6 +29,7 @@ TESTS = [
> > &nbsp; 'compilebench',
> > &nbsp; 'dbench',
> > &nbsp; 'disktest',
> > + &nbsp;'firmware_VbootCrypto',
> > &nbsp; 'gl_Bench',
> > &nbsp; 'hardware_StorageFio',
> > &nbsp; 'ltp',
> >
> >
> >
>

[kmixter1, 2010-04-07 19:31:22]

LGTM