chrome/browser/bookmarks/bookmark_storage.cc - Issue 16270: Change the signature of JSONReader::Read() and related methods to be more

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_storage.cc

Issue 16270: Change the signature of JSONReader::Read() and related methods to be more (Closed)

Patch Set: fixens Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_storage.cc

diff --git a/chrome/browser/bookmarks/bookmark_storage.cc b/chrome/browser/bookmarks/bookmark_storage.cc

index e6e9a5037562a0ab9ef75fe53bcc42369abc3b46..23f47b40b0b3aa5e92369cfcbb7393ee2d4d8334 100644

--- a/chrome/browser/bookmarks/bookmark_storage.cc

+++ b/chrome/browser/bookmarks/bookmark_storage.cc

@@ -167,7 +167,7 @@ void BookmarkStorageBackend::Read(scoped_refptr<BookmarkStorage> service,

Value* root = NULL;

if (bookmark_file_exists) {

JSONFileValueSerializer serializer(path);

- serializer.Deserialize(&root, NULL);

+ root = serializer.Deserialize(NULL);

}

// BookmarkStorage takes ownership of root.