Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1939)

Unified Diff: chrome/browser/autocomplete/search_provider.cc

Issue 16270: Change the signature of JSONReader::Read() and related methods to be more (Closed)
Patch Set: fixens Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.cc
diff --git a/chrome/browser/autocomplete/search_provider.cc b/chrome/browser/autocomplete/search_provider.cc
index 32c2fb2bf3444ac6e89044638ed76f54788ad6a4..17bdcc8dd62f1e7b65efea53b8553310e7c1490f 100644
--- a/chrome/browser/autocomplete/search_provider.cc
+++ b/chrome/browser/autocomplete/search_provider.cc
@@ -129,13 +129,14 @@ void SearchProvider::OnURLFetchComplete(const URLFetcher* source,
}
}
- JSONStringValueSerializer deserializer(json_data);
- deserializer.set_allow_trailing_comma(true);
- Value* root_val = NULL;
- have_suggest_results_ = status.is_success() && (response_code == 200) &&
- deserializer.Deserialize(&root_val, NULL) &&
- ParseSuggestResults(root_val);
- delete root_val;
+ if (status.is_success() && response_code == 200) {
+ JSONStringValueSerializer deserializer(json_data);
+ deserializer.set_allow_trailing_comma(true);
+ scoped_ptr<Value> root_val(deserializer.Deserialize(NULL));
+ have_suggest_results_ =
+ root_val.get() && ParseSuggestResults(root_val.get());
+ }
+
ConvertResultsToAutocompleteMatches();
listener_->OnProviderUpdate(!suggest_results_.empty());
}

Powered by Google App Engine
This is Rietveld 408576698