Change how the calculation is performed for determining the location of the a...

Change how the calculation is performed for determining the location of the arrow tip in a bubble window.

BUG=40406
TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests. 3) Alter the user interface resolution (such as by using Quartz Debug) and verify bubble is placed correctly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43694

[Avi (use Gerrit), 2010-04-05 22:56:37]

On 2010/04/05 22:53:56, mrossetti wrote:
> 

Don't forget to check with resolution independence; keep bug 19476 in mind.

[Scott Hess - ex-Googler, 2010-04-05 23:07:16]

LGTM.

http://codereview.chromium.org/1623002/diff/1/7
File chrome/browser/cocoa/info_bubble_view.mm (right):

http://codereview.chromium.org/1623002/diff/1/7#newcode97
chrome/browser/cocoa/info_bubble_view.mm:97: NSPoint arrowTip =
NSMakePoint(NSMaxX(bounds), NSMaxY(bounds));
If kTopLeft, arrowTip.x should be NSMinX(bounds) + tipXOffset, I think.

[mrossetti, 2012-05-14 21:35:09]

I'm flushing really old comments. Please feel free to ignore.

http://codereview.chromium.org/1623002/diff/1/chrome/browser/cocoa/info_bubbl...
File chrome/browser/cocoa/info_bubble_view.mm (right):

http://codereview.chromium.org/1623002/diff/1/chrome/browser/cocoa/info_bubbl...
chrome/browser/cocoa/info_bubble_view.mm:97: NSPoint arrowTip =
NSMakePoint(NSMaxX(bounds), NSMaxY(bounds));
On 2010/04/05 23:07:16, shess wrote:
> If kTopLeft, arrowTip.x should be NSMinX(bounds) + tipXOffset, I think.

Done.