Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 1623002: Change how the calculation is performed for determining the location of the a... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_controller.mm
===================================================================
--- chrome/browser/cocoa/browser_window_controller.mm (revision 43634)
+++ chrome/browser/cocoa/browser_window_controller.mm (working copy)
@@ -1372,14 +1372,12 @@
return phase;
}
-- (NSPoint)topRightForBubble {
+- (NSPoint)pointForBubbleArrowTip {
NSRect rect = [toolbarController_ starIconInWindowCoordinates];
- NSPoint p = NSMakePoint(NSMaxX(rect), NSMinY(rect)); // bottom right
-
- // Adjust top-right based on our knowledge of how the view looks.
- p.x += 31;
- p.y += 5;
-
+ // Determine the point of the arrow of the bubble window.
+ NSPoint p = rect.origin;
+ p.x += (NSWidth(rect) / 2.0) + 1.0; // Star is not exactly in center.
+ p.y += 4;
return p;
}
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.h ('k') | chrome/browser/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698