Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1613020: Merge 44735 - With the ChromeFrame moniker patch on, the data cache maintaine... (Closed)

Created:
10 years, 8 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 44735 - With the ChromeFrame moniker patch on, the data cache maintained to indicate whether we should switch to Chrome, was not being drained correctly to the delegate, resulting in the delegate continuing to wait for more data when there was none. This caused sites like go/wave to not redirect correctly to CF. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365 Bug=41365 Review URL: http://codereview.chromium.org/1637017 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome_frame/bind_context_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/test/urlmon_moniker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 6 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 8 months ago (2010-04-16 01:43:19 UTC) #1
amit
10 years, 8 months ago (2010-04-16 01:44:44 UTC) #2
lgtm

On Thu, Apr 15, 2010 at 6:43 PM, <ananta@chromium.org> wrote:

> Reviewers: ananta,
>
> Description:
> Merge 44735 - With the ChromeFrame moniker patch on, the data cache
> maintained
> to indicate whether we should switch to Chrome, was not being
> drained correctly to the delegate, resulting in the delegate continuing to
> wait
> for more data when there was none. This caused
> sites like go/wave to not redirect correctly to CF.
>
> Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365
>
> Bug=41365
>
> Review URL: http://codereview.chromium.org/1637017
>
> TBR=ananta@chromium.org
>
> Please review this at http://codereview.chromium.org/1613020/show
>
> SVN Base: svn://svn.chromium.org/chrome/branches/375/src/
>
> Affected files:
>  M     chrome_frame/bind_context_info.h
>  M     chrome_frame/test/urlmon_moniker_unittest.cc
>  M     chrome_frame/urlmon_bind_status_callback.h
>  M     chrome_frame/urlmon_bind_status_callback.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698