Issue 1637017: With the ChromeFrame moniker patch on, the data cache maintained to indicate ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1637017: With the ChromeFrame moniker patch on, the data cache maintained to indicate ... (Closed)

Created:
10 years, 8 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

With the ChromeFrame moniker patch on, the data cache maintained to indicate whether we should switch to Chrome, was not being drained correctly to the delegate, resulting in the delegate continuing to wait for more data when there was none. This caused sites like go/wave to not redirect correctly to CF. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365 Bug=41365 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44735

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -13 lines)			Patch
M	chrome_frame/bind_context_info.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome_frame/test/urlmon_moniker_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/urlmon_bind_status_callback.h	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome_frame/urlmon_bind_status_callback.cc	View	6 chunks	+8 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm