Issue 1613004: Issue a warning if naclsdk_mode=manual is specified with ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1613004: Issue a warning if naclsdk_mode=manual is specified with ARM. (Closed)

Created:
10 years, 8 months ago by adonovan

Modified:
9 years, 7 months ago

Reviewers:
robertm

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Visibility:
Public.

Description

Various fixes: - Issue a warning if naclsdk_mode=manual is specified with ARM. - Remove naclsdk_mode=manual from toolchain-creator.sh. - Switch LIBDIR_X8632_{1,2} - Read LLC_SFI_X86 from environment. - Don't splice in the REACHABLE_FUNCTION_SYMBOLS in ld. Committed: http://code.google.com/p/nativeclient/source/detail?r=1958

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -18 lines)			Patch
M	SConstruct	View	1 2 3 4 5	1 chunk	+7 lines, -4 lines	0 comments	Download
M	tools/llvm/llvm-fake.py	View	2 3 4 5	6 chunks	+16 lines, -7 lines	0 comments	Download
M	tools/llvm/toolchain-creator.sh	View	2 3 4 5	5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

robertm

10 years, 8 months ago (2010-04-05 21:39:54 UTC) #7

LGTM

as per our verbal communication, please revert some of the x86 changes in
llvm-fake.py

Expand Messages | Collapse Messages