Issue a warning if naclsdk_mode=manual is specified with ARM.

tools/llvm/toolchain-creator.sh

 #!/bin/bash
 # Copyright 2009 The Native Client Authors.  All rights reserved.
 # Use of this source code is governed by a BSD-style license that can
 # be found in the LICENSE file.
 #
 #@ This script builds the arm untrusted SDK.
 #@ NOTE: It must be run from the native_client/ directory.
 #@ NOTE: you should source: set_arm_(un)trusted_toolchain.sh
 #@       before running it
 ######################################################################
@@ skipping 12 matching lines @@
 # Config
 ######################################################################
 
 set -o nounset
 set -o errexit
 
 
 # NOTE: gcc and llvm have to be synchronized
 #       we have chosen toolchains which both are based on gcc-4.2.1
 
-readonly CS_URL=http://www.codesourcery.com/sgpp/lite/arm/portal/package1787/public/arm-none-linux-gnueabi/arm-2007q3-51-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
+readonly CS_URL=http://www.codesourcery.com/sgpp/lite/arm/portal/package1787/\
+public/arm-none-linux-gnueabi/\
+arm-2007q3-51-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2
 
 
 readonly INSTALL_ROOT=$(pwd)/toolchain/linux_arm-untrusted
 readonly LLVM_PKG_PATH=$(readlink -f ../third_party/llvm)
 readonly LLVM_SVN_REV=88663
 readonly LLVMGCC_SVN_REV=88663
 readonly MAKE_OPTS="-j6 VERBOSE=1"
 
 export TMP=/tmp/crosstool-untrusted
 export CODE_SOURCERY_PKG_PATH=${INSTALL_ROOT}/codesourcery
@@ skipping 212 matching lines @@
 
 # we copy some useful tools after building them first
 InstallMiscTools() {
    Banner "building and installing misc tools"
 
    # TODO(robertm): revisit some of these options
    Run "sel loader" \
           ./scons MODE=nacl,opt-linux \
           platform=arm \
           sdl=none \
-          naclsdk_mode=manual \
           naclsdk_validate=0 \
           sysinfo= \
           sel_ldr
    rm -rf  ${INSTALL_ROOT}/tools-arm
    mkdir ${INSTALL_ROOT}/tools-arm
    cp scons-out/opt-linux-arm/obj/src/trusted/service_runtime/sel_ldr\
      ${INSTALL_ROOT}/tools-arm
 
    Run "validator" \
            ./scons MODE=opt-linux \
-           naclsdk_mode=manual \
            targetplatform=arm \
            sysinfo= \
            arm-ncval-core
    rm -rf  ${INSTALL_ROOT}/tools-x86
    mkdir ${INSTALL_ROOT}/tools-x86
-   cp scons-out/opt-linux-x86-32-to-arm/obj/src/trusted/validator_arm/v2/arm-ncval-core\
-       ${INSTALL_ROOT}/tools-x86
+   cp scons-out/opt-linux-x86-32-to-arm/obj/src/trusted/validator_arm/v2/\
+arm-ncval-core ${INSTALL_ROOT}/tools-x86
 }
 
 
 # the driver is a simple python script which changes its behavior
 # depending under the name it is invoked as
 InstallDriver() {
   local dir=${INSTALL_ROOT}/arm-none-linux-gnueabi/
   Banner "installing driver adaptors to ${dir}"
   rm -f  ${dir}/llvm-fake*
   cp tools/llvm/llvm-fake.py ${dir}/
@@ skipping 16 matching lines @@
 
   SubBanner "building newib"
   rm -rf toolchain/linux_arm-untrusted/arm-newlib/
   tools/llvm/setup_arm_newlib.sh
 
   SubBanner "building extra sdk libs"
   rm -rf scons-out/nacl_extra_sdk-arm/
   ./scons MODE=nacl_extra_sdk \
           platform=arm \
           sdl=none \
-          naclsdk_mode=manual \
           naclsdk_validate=0 \
           extra_sdk_clean \
           extra_sdk_update_header \
           install_libpthread \
           extra_sdk_update
 }
 
 
 InstallExamples() {
   Banner "installing examples into ${INSTALL_ROOT}/examples"
   rm -rf  ${INSTALL_ROOT}/examples/
   cp -r  tools/llvm/arm_examples ${INSTALL_ROOT}/examples/
 }
 
 
 # NOTE: Experiment x86-32 support
 AddX86Basics32() {
   Banner "installing experimental x86-32 support"
   local libdir="${INSTALL_ROOT}/x86-32sfi-lib"
   mkdir -p ${libdir}
 
   SubBanner "rebuilding stubs for x86"
   rm -f scons-out/nacl_extra_sdk-x86-32/obj/src/untrusted/stubs/*.o
   # NOTE: this does way too much - we only want the stubs
   ./scons MODE=nacl_extra_sdk platform=x86-32 \
       extra_sdk_clean extra_sdk_update_header extra_sdk_update
   cp scons-out/nacl_extra_sdk-x86-32/obj/src/untrusted/stubs/*.o ${libdir}
 
   SubBanner "installing x86 libgcc libs into ${libdir}"
-  cp -r toolchain/linux_x86-32/sdk/nacl-sdk/lib/gcc/nacl/4.2.2/libgcc.a ${libdir}
+  cp -r toolchain/linux_x86-32/sdk/nacl-sdk/lib/gcc/nacl/4.2.2/libgcc.a \
+    ${libdir}
 
   local toolsdir="${INSTALL_ROOT}/x86-32sfi-tools"
   mkdir -p ${toolsdir}
   SubBanner "installing x86 linker script and tools into ${toolsdir}"
   cp tools/llvm/ld_script_x86_untrusted ${toolsdir}
   cp toolchain/linux_x86-32/sdk/nacl-sdk/bin/nacl-as ${toolsdir}
   cp toolchain/linux_x86-32/sdk/nacl-sdk/bin/nacl-ld ${toolsdir}
 }
 
 
@@ skipping 161 matching lines @@
 #@ tar <tarball>
 #@
 #@   tar everything up
 if [ ${MODE} = 'tar' ] ; then
   CreateTarBall $1
   exit 0
 fi
 
 echo "ERROR: unknown mode ${MODE}"
 exit -1