Issue 1607006: VBoot Reference: Output debug information using debug() instead of fprintf().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1607006: VBoot Reference: Output debug information using debug() instead of fprintf(). (Closed)

Created:
10 years, 8 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

VBoot Reference: Output debug information using debug() instead of fprintf(). This should make it easier to switch off debug messages if needed. TESTS=builds fine, autotest builds fine (using both arm/x86-generic)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -40 lines)			Patch
M	src/platform/vboot_reference/common/rollback_index.c	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/platform/vboot_reference/cryptolib/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/misclibs/file_keys.c	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/misclibs/signature_digest.c	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/tests/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform/vboot_reference/tests/big_firmware_tests.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/tests/big_kernel_tests.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_verify_benchmark.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_rollback_tests.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_verify_benchmark.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/tests/rollback_index_mock.c	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/platform/vboot_reference/tests/rsa_verify_benchmark.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/tests/test_common.c	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages