src/platform/vboot_reference/tests/firmware_verify_benchmark.c - Issue 1607006: VBoot Reference: Output debug information using debug() instead of fprintf().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/vboot_reference/tests/firmware_verify_benchmark.c

Issue 1607006: VBoot Reference: Output debug information using debug() instead of fprintf(). (Closed)

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/platform/vboot_reference/tests/big_kernel_tests.c ('k') | src/platform/vboot_reference/tests/kernel_rollback_tests.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/platform/vboot_reference/tests/firmware_verify_benchmark.c

diff --git a/src/platform/vboot_reference/tests/firmware_verify_benchmark.c b/src/platform/vboot_reference/tests/firmware_verify_benchmark.c

index 3d06dc93cf34072f2f6f35364eefae1b164d6eb0..c69ada73fa805dd1ae9e2f583c22a4d7bc11c987 100644

--- a/src/platform/vboot_reference/tests/firmware_verify_benchmark.c

+++ b/src/platform/vboot_reference/tests/firmware_verify_benchmark.c

@@ -60,7 +60,7 @@ int SpeedTestAlgorithm(int algorithm) {

snprintf(file_name, FILE_NAME_SIZE, "testkeys/key_rsa%d.keyb", key_size);

firmware_sign_key = BufferFromFile(file_name, &len);

if (!firmware_sign_key) {

- fprintf(stderr, "Couldn't read pre-processed firmware signing key.\n");

+ debug("Couldn't read pre-processed firmware signing key.\n");

error_code = 1;

goto cleanup;

}

@@ -75,7 +75,7 @@ int SpeedTestAlgorithm(int algorithm) {

"testkeys/key_rsa8192.pem",

firmware_sign_key_file);

if (!firmware_blobs[i]) {

- fprintf(stderr, "Couldn't generate test firmware images.\n");

+ debug("Couldn't generate test firmware images.\n");

error_code = 1;

goto cleanup;

}

@@ -84,7 +84,7 @@ int SpeedTestAlgorithm(int algorithm) {

/* Get pre-processed key used for verification. */

root_key_blob = BufferFromFile("testkeys/key_rsa8192.keyb", &len);

if (!root_key_blob) {

- fprintf(stderr, "Couldn't read pre-processed rootkey.\n");

+ debug("Couldn't read pre-processed rootkey.\n");

error_code = 1;

goto cleanup;

}

@@ -95,7 +95,7 @@ int SpeedTestAlgorithm(int algorithm) {

for (j = 0; j < NUM_OPERATIONS; ++j) {

if (VERIFY_FIRMWARE_SUCCESS !=

VerifyFirmware(root_key_blob, firmware_blobs[i]))

- fprintf(stderr, "Warning: Firmware Verification Failed.\n");

+ debug("Warning: Firmware Verification Failed.\n");

}

StopTimer(&ct);

msecs = (float) GetDurationMsecs(&ct) / NUM_OPERATIONS;