Issue 160642: Timur's suggested fix for the data race described in bug 18488...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160642: Timur's suggested fix for the data race described in bug 18488... (Closed)

Created:
11 years, 4 months ago by dank

Modified:
4 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Timur's suggested fix for the data race described in bug 18488 BUG=18488 TEST=install valgrind with tsan support, then run ui tests under tsan

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/history/history_marshaling.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

dank

11 years, 4 months ago (2009-08-05 13:53:58 UTC) #1

I couldn't find the original author of the
line in question, but Brett appears
early in the logs.