Issue 160634: Don't force-export V8 symbols unless v8 is built as a shared library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160634: Don't force-export V8 symbols unless v8 is built as a shared library. (Closed)

Created:
11 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

On Linus don't force-export V8 symbols unless v8 is built as a shared library. This lands: http://codereview.chromium.org/160556. TBR=piman@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=2622

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	SConstruct	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/v8.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	include/v8-debug.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM. Thank you !