include/v8.h - Issue 160634: Don't force-export V8 symbols unless v8 is built as a shared library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 160634: Don't force-export V8 symbols unless v8 is built as a shared library. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

===================================================================

--- include/v8.h (revision 2621)

+++ include/v8.h (working copy)

@@ -85,11 +85,10 @@

#include <stdint.h>

-// Setup for Linux shared library export. There is no need to destinguish

-// neither between building or using the V8 shared library nor between using

-// the shared or static V8 library as there is on Windows. Therefore there is

-// no checking of BUILDING_V8_SHARED and USING_V8_SHARED.

-#if defined(__GNUC__) && (__GNUC__ >= 4)

+// Setup for Linux shared library export. There is no need to distinguish

+// between building or using the V8 shared library, but we should not

+// export symbols when we are building a static library.

+#if defined(__GNUC__) && (__GNUC__ >= 4) && defined(V8_SHARED)

#define V8EXPORT __attribute__ ((visibility("default")))

#define V8EXPORT_INLINE __attribute__ ((visibility("default")))

#else // defined(__GNUC__) && (__GNUC__ >= 4)

« no previous file with comments | « SConstruct ('k') | include/v8-debug.h » ('j') | no next file with comments »