Issue 160622: Add patch to the Linux build deps script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160622: Add patch to the Linux build deps script. (Closed)

Created:
11 years, 4 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add patch to the Linux build deps script. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22669

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I can't believe my vanilla Ubuntu machine didn't come with patch!

11 years, 4 months ago (2009-08-05 01:29:25 UTC) #1

not_the_right_dank

11 years, 4 months ago (2009-08-05 01:48:55 UTC) #2

Lgtm

On Aug 4, 2009 6:29 PM, <thestig@chromium.org> wrote:


Reviewers: dank,

Message:
I can't believe my vanilla Ubuntu machine didn't come with patch!

Description:
Add patch to the Linux build deps script.

Please review this at http://codereview.chromium.org/160622

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
 M     build/install-build-deps.sh


Index: build/install-build-deps.sh
===================================================================
--- build/install-build-deps.sh (revision 22288)
+++ build/install-build-deps.sh (working copy)
@@ -89,7 +89,7 @@
 # Packages need for development
 dev_list="bison fakeroot flex g++ g++-multilib gperf libasound2-dev
          libcairo2-dev libgconf2-dev libglib2.0-dev libgtk2.0-dev
libnspr4-dev
-          libnss3-dev libsqlite3-dev lighttpd msttcorefonts perl php5-cgi
+          libnss3-dev libsqlite3-dev lighttpd msttcorefonts patch perl
php5-cgi
          pkg-config python subversion wdiff"

 # Full list of required run-time libraries

Expand Messages | Collapse Messages