Add support to the CFG builder for non-short-circuited binary...

Add support to the CFG builder for non-short-circuited binary
expressions.  Add compilation support in fast mode (optimized for
compilation time and code size).

This breaks one debugger test each on ARM and IA32 (expectedly).

Committed: http://code.google.com/p/v8/source/detail?r=2628

[Kevin Millikin (Chromium), 2009-08-04 15:01:10]

There are a lot of changes to comments in cfg.h.

It's a known issue that appending lists of expressions like this is quadratic in
the size of the expression AST (copying the entire right-hand subtree at each
level).  That will be solve by a linked representation of instruction lists.

[Kevin Millikin (Chromium), 2009-08-04 15:02:24]

Added Erik to take a look at cfg-arm.cc.  Added Bill to take a look at
cfg-x64.cc.  Double check that I didn't write anything silly or miss a
platform-specific idiom.

[Kasper Lund, 2009-08-05 07:37:03]

I only looked briefly at this, so I think it makes a lot of sense for Bill to
spend some time on a more careful review of your evolving compilation strategy.
LGTM.

http://codereview.chromium.org/160584/diff/1/2
File src/cfg.h (right):

http://codereview.chromium.org/160584/diff/1/2#newcode309
Line 309: Instruction(Location* loc) : loc_(loc) {}
explicit

http://codereview.chromium.org/160584/diff/1/2#newcode583
Line 583: // An Expression Builder traverses an expression and returns an open
CFG
ExpressionBuilder

[William Hesse, 2009-08-05 13:22:24]

LGTM.  Beautiful.