Issue 160520: X64: Add missing pop when calling handler with Out-of-memory exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160520: X64: Add missing pop when calling handler with Out-of-memory exception. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Add missing pop when calling handler with Out-of-memory exception. Committed: http://code.google.com/p/v8/source/detail?r=2618

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/x64/disasm-x64.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 4 months ago (2009-08-03 16:08:01 UTC) #2

Why is this so much different from IA32 and ARM?  On those platforms, we unwind
the stack using the stack pointer rather than an auxiliary register (rdx), and
then we pop the next handler link from the block to set the top handler pointer.

Expand Messages | Collapse Messages