Issue 160501: Try again to land: http://codereview.chromium.org/160483

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160501: Try again to land: http://codereview.chromium.org/160483 (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Try again to land: http://codereview.chromium.org/160483 Ever closer. Extract a client interface out of CrxInstaller and use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. TBR=mpcomplete@chromium.org BUG=17932 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22244

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+377 lines, -190 lines)			Patch
M	chrome/browser/download/download_manager.cc	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	6 chunks	+62 lines, -34 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View	4 chunks	+105 lines, -74 lines	0 comments	Download
A	chrome/browser/extensions/extension_install_ui.h	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+118 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	3 chunks	+6 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	8 chunks	+23 lines, -48 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View	3 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/theme_preview_infobar_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/theme_preview_infobar_delegate.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download