Issue 160483: Ever closer. Extract a client interface out of CrxInstaller and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160483: Ever closer. Extract a client interface out of CrxInstaller and (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Ever closer. Extract a client interface out of CrxInstaller and use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. BUG=17932 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22228

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 4

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -171 lines)			Patch
M	chrome/browser/download/download_manager.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	1	5 chunks	+56 lines, -34 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		4 chunks	+77 lines, -69 lines	3 comments	Download
A	chrome/browser/extensions/extension_install_ui.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_install_ui.cc	View	1	1 chunk	+99 lines, -0 lines	1 comment	Download
M	chrome/browser/extensions/extensions_service.h	View		3 chunks	+6 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View		7 chunks	+17 lines, -48 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View		3 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 4 months ago (2009-07-31 22:33:39 UTC) #2

LGTM after small changes

http://codereview.chromium.org/160483/diff/22/1002
File chrome/browser/extensions/crx_installer.cc (right):

http://codereview.chromium.org/160483/diff/22/1002#newcode64
Line 64: static_cast<bool (*) (const FilePath&, bool)>(&file_util::Delete),
why is this cast necessary?  How about a wrapper function instead?

http://codereview.chromium.org/160483/diff/22/1002#newcode174
Line 174: ExtensionErrorReporter::GetInstance()->ReportError(error, false);  //
quiet
does quiet/noisy make sense anymore now that we have the installer client?

http://codereview.chromium.org/160483/diff/22/1002#newcode197
Line 197: ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(frontend_.get(),
why not add a ReportSuccessFromUIThread, like you do for the failure case?

http://codereview.chromium.org/160483/diff/22/1004
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/160483/diff/22/1004#newcode96
Line 96: LOG(ERROR) << error.c_str();
nit: add a "Extension install failed:" prefix to this message

Expand Messages | Collapse Messages