Since bookmark copy/paste is not impl on non-Windows platforms, don't remove ...

Since bookmark copy/paste is not impl on non-Windows platforms, don't remove nodes when cutting.

BUG=18152
TEST=none

TBR=erg


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22221

[Elliot Glaysher, 2009-07-31 23:39:41]

LGTM

On Fri, Jul 31, 2009 at 4:38 PM, <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Since bookmark copy/paste is not impl on non-Windows platforms, don't
> remove nodes when cutting.
>
> BUG=3D18152
> TEST=3Dnone
>
> TBR=3Derg
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=3Drev&revision=3D22=
221
>
> Please review this at http://codereview.chromium.org/160488
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_utils.cc
>
>
> Index: chrome/browser/bookmarks/bookmark_utils.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/bookmarks/bookmark_utils.cc =A0(revision 22220)
> +++ chrome/browser/bookmarks/bookmark_utils.cc =A0(working copy)
> @@ -368,12 +368,17 @@
> =A0 // implemented somewhere else?
> =A0#endif
>
> + =A0// The following works cross-platform but I'm disabling it for now s=
o
> that
> + =A0// users who Cut a bookmark or folder won't lose it without being ab=
le to
> + =A0// paste it.
> +#if defind(OS_WIN)
> =A0 if (remove_nodes) {
> =A0 =A0 for (size_t i =3D 0; i < nodes.size(); ++i) {
> =A0 =A0 =A0 model->Remove(nodes[i]->GetParent(),
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 nodes[i]->GetParent()->IndexOfChi=
ld(nodes[i]));
> =A0 =A0 }
> =A0 }
> +#endif
> =A0}
>
> =A0void PasteFromClipboard(BookmarkModel* model,
>
>
>